ensure execution_context is propagated to additional_codecs #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsvd
approved these changes
Apr 12, 2022
too complex to be a guard clause. Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
yaauie
added a commit
to yaauie/logstash-input-http
that referenced
this pull request
Apr 12, 2022
…ogstash-plugins#152) * ensure execution_context is propagated to additional_codecs * more closely specify the desired behaviour for pipeline.ecs_compatibility * version bump * restructure conditional too complex to be a guard clause. Co-authored-by: João Duarte <jsvd@users.noreply.github.com> Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the issue where a pipeline is started with
pipeline.ecs_compatibilityset to a value other than the global value for that setting, and theadditional_codecsinstantiated by this plugin do not respect the pipeline setting.It does so by reaching into Logstash internals IFF the necessary
::LogStash::Plugins::Contextualizeris present.In the long-run, I would prefer to provide a plugin factory from Logstash core (see: logstash-plugins/logstash-mixin-plugin_factory_support#1), but this solves the immediate need for this particular plugin.